[AutoDiff] Store original declaration in DifferentiableAttr.
#27985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fails locally during stdlib compilation with a nondescript error: Triggering tests to see if the issue is reproducible. |
|
@swift-ci Please test tensorflow |
dan-zheng
commented
Oct 31, 2019
|
|
||
| FuncDecl *originalDecl = cast<FuncDecl>(MF.getDecl(originalDeclId)); |
There was a problem hiding this comment.
The issue is this line causes an infinite loop: we cannot deserialize the original declaration here because @differentiable attributes are deserialized as part of deserializing the original declaration.
There was a problem hiding this comment.
Fixed in 4df0307 via ad-hoc deserialization logic. I couldn't think of a better solution.
Store original `AbstractFunctionDecl` in `DifferentiableAttr`. This is important for requestifying `DifferentiableAttr->getParameterIndices()`: we want the ability to resolve parameter indices without needing to pass the original `AbstractFunctionDecl` to `getParameterIndices`.
Deserializing the original declaration DeclID in `@differentiable` attributes does not work because it causes `@differentiable` attribute deserialization to enter an infinite loop. Instead, use ad-hoc deserialization logic to set the original declaration in `@differentiable` attributes. Add round-trip `@differentiable` attribute AST serialization test. `@differentiable` attribute serialization asserts that the original declaration is set.
dan-zheng
force-pushed
the
diff-attr-store-original-decl
branch
from
93ce245 to
4df0307
Compare
|
Triggering extended test suite ( |
|
Extended test suite failed while building Please hold off on merging; more changes are necessary to support requestifying |
marcrasi
reviewed
Oct 31, 2019
Store original declaration `Decl *` in `DifferentiableAttr` instead of casting to `AbstractFunctionDecl *`. This helps ensure that the original declaration is set.
dan-zheng
force-pushed
the
diff-attr-store-original-decl
branch
from
0c62032 to
e2be0a2
Compare
dan-zheng
force-pushed
the
diff-attr-store-original-decl
branch
from
4415f95 to
12bd568
Compare
marcrasi
approved these changes
Nov 1, 2019
|
@swift-ci Please test tensorflow |
|
Confirmed that extended test suite has passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store original declaration
Decl *inDifferentiableAttr.This is important for requestifying
DifferentiableAttr->getParameterIndices(): we want the ability toresolve parameter indices without needing to pass the original
AbstractFunctionDecltogetParameterIndices.Add round-trip
@differentiableattribute AST serialization test.@differentiableattribute type-checking and serialization assertthat the original declaration is set.
A step towards unblocking the
swift-DEVELOPMENT-SNAPSHOT-2019-10-24-amerge.