[AutoDiff] Clean up @transposing attribute type-checking.
#27988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove dead code and unused parameters, unify style. Fix capacity of `@transposing` attribute parameter indices. The correct capacity is: non-wrt parameter count + wrt parameter count - 1. Todos: - More clean up; this clean up was not comprehensive. - Consider revamping type-checking for instance methods so that `@transposing` functions can always be declared in same type context as their original declaration.
rxwei
approved these changes
Oct 31, 2019
|
@swift-ci Please test tensorflow |
dan-zheng
commented
Oct 31, 2019
| numUncurriedParams += resultFnType->getNumParams(); | ||
| } | ||
| auto numParams = numUncurriedParams + parsedWrtParams.size() - 1; | ||
| auto parameterBits = SmallBitVector(numParams); |
There was a problem hiding this comment.
Note: @transposing attribute parameter indices capacity is fixed here.
Correct capacity: non-wrt parameter count + wrt parameter count - 1.
| @@ -3954,9 +3904,14 @@ void AttributeChecker::visitTransposingAttr(TransposingAttr *attr) { | |||
| return; | |||
| } | |||
|
|
|||
| bool wrtSelf = false; | |||
| if (!parsedWrtParams.empty()) | |||
| wrtSelf = parsedWrtParams.front().getKind() == | |||
There was a problem hiding this comment.
Todo: make this wrtSelf logic more robust than checking parsedWrtParams.front().getKind().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dead code and unused parameters, unify style.
Fix capacity of
@transposingattribute parameter indices.The correct capacity is:
non-wrt parameter count + wrt parameter count - 1.Todos:
@transposingfunctions can always be declared in same typecontext as their original declaration.