Provide fix-its when implementing a protocol method with bridged types. #2799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the protocol version of 7bfdd4a: if a protocol requirement has a newly-bridged type (say, 'URL' instead of 'NSURL'), then any conforming types will need to update their implementations of the requirement. Reuse the override-checking mechanism to do so when we're reasonably confident about it. This slots the checking into the existing protocol diagnostics, which doesn't result in the best user experience. note: protocol requires property 'prop' with type 'Refrigerator?' var prop: Refrigerator? { get } ^ note: candidate has non-matching type 'APPRefrigerator?' var prop: APPRefrigerator? { ^ ~~~~~~~~~~~~~~~~ Refrigerator? But we can come back and improve that later; right now this is better than nothing. rdar://problem/26237030
|
@DougGregor It's starting to get late to pull this into the preview 1 branch, but can you look over it anyway? It's mostly the same as the WIP. I'd also appreciate comments on any important test cases I might have missed, since the space of possible test cases is very large. @swift-ci Please test |
|
Yeah, this looks good. Protocol conformance failure diagnostics need a mega-overhaul at some point, but this is a step forward for now. |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jun 1, 2016
…s. (swiftlang#2799) This is the protocol version of 7bfdd4a: if a protocol requirement has a newly-bridged type (say, 'URL' instead of 'NSURL'), then any conforming types will need to update their implementations of the requirement. Reuse the override-checking mechanism to do so when we're reasonably confident about it. This slots the checking into the existing protocol diagnostics, which doesn't result in the best user experience. note: protocol requires property 'prop' with type 'Refrigerator?' var prop: Refrigerator? { get } ^ note: candidate has non-matching type 'APPRefrigerator?' var prop: APPRefrigerator? { ^ ~~~~~~~~~~~~~~~~ Refrigerator? But we can come back and improve that later; right now this is better than nothing. rdar://problem/26237030 (cherry picked from commit 258e2bb)
tkremenek
pushed a commit
that referenced
this pull request
Jun 1, 2016
…s. (#2799) (#2823) This is the protocol version of 7bfdd4a: if a protocol requirement has a newly-bridged type (say, 'URL' instead of 'NSURL'), then any conforming types will need to update their implementations of the requirement. Reuse the override-checking mechanism to do so when we're reasonably confident about it. This slots the checking into the existing protocol diagnostics, which doesn't result in the best user experience. note: protocol requires property 'prop' with type 'Refrigerator?' var prop: Refrigerator? { get } ^ note: candidate has non-matching type 'APPRefrigerator?' var prop: APPRefrigerator? { ^ ~~~~~~~~~~~~~~~~ Refrigerator? But we can come back and improve that later; right now this is better than nothing. rdar://problem/26237030 (cherry picked from commit 258e2bb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the protocol version of 7bfdd4a: if a protocol requirement has a newly-bridged type (say, 'URL' instead of
NSURL), then any conforming types will need to update their implementations of the requirement. Reuse the override-checking mechanism to do so when we're reasonably confident about it.This slots the checking into the existing protocol diagnostics, which
doesn't result in the best user experience.
But we can come back and improve that later; right now this is better
than nothing.
rdar://problem/26237030
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.