Skip to content

Compiler crashers: Sync with https://github.com/practicalswift/swift-compiler-crashes #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2015
Merged

Compiler crashers: Sync with https://github.com/practicalswift/swift-compiler-crashes #280

merged 4 commits into from
Dec 6, 2015

Conversation

practicalswift
Copy link
Contributor

Add 342 compiler crashes.

@gribozavr
Copy link
Contributor

Thanks! I'll run tests on Linux and OS X and merge.

@gribozavr gribozavr self-assigned this Dec 6, 2015
@radex
Copy link
Contributor

radex commented Dec 6, 2015

@practicalswift FWIW I think there are a bunch more test cases from swift-compiler-crashes that didn't get synced — I can't, for example, find this one: https://github.com/practicalswift/swift-compiler-crashes/blob/736d5c8bee75f676ff3750e4ad3165d81059fe03/crashes/26296-duplicate-subscript-declaration.swift

@gribozavr
Copy link
Contributor

These tests don't crash on Linux and OS X, please move them to the directory for fixed crashers:

Failing Tests (4):
    Swift :: compiler_crashers/27818-swift-astvisitor.swift
    Swift :: compiler_crashers/28181-llvm-irbuilder.swift
    Swift :: compiler_crashers/28182-anonymous-namespace-favorcalloverloads.swift
    Swift :: compiler_crashers/28183-swift-typebase-isequal.swift

@stefanstefan2001
Copy link

I know this isn't the best place to ask. How do you run the test ?

@gribozavr
Copy link
Contributor

@stefanstefan2001 utils/build-script -RT. More information in https://github.com/apple/swift/blob/master/docs/Testing.rst.

@stefanstefan2001
Copy link

@gribozavr Thank you.

@practicalswift
Copy link
Contributor Author

@gribozavr Let me know if any further adjustments are needed :-)

@jtbandes
Copy link
Contributor

jtbandes commented Dec 6, 2015

I think it's quite possible that my PRs #253, #266, and #272 will fix some of these, so might want to wait for them to be merged, then re-run the tests. (Or I could rebase, but I'd have to do it 3 times 😳)

@lattner
Copy link
Contributor

lattner commented Dec 6, 2015

Nice! Thank you @practicalswift , you continue to be awesome!

@gribozavr
Copy link
Contributor

@practicalswift One more thing: these two tests are actually valid programs, so they don't need not in their RUN line:

Failing Tests (2):
    Swift :: compiler_crashers_fixed/27818-swift-astvisitor.swift
    Swift :: compiler_crashers_fixed/28181-llvm-irbuilder.swift

@practicalswift
Copy link
Contributor Author

@gribozavr Fixed! Sorry about this - still trying to grasp all aspects of the RUN annotations used in the project :-)

@gribozavr gribozavr merged commit a35567d into swiftlang:master Dec 6, 2015
@practicalswift
Copy link
Contributor Author

@radex Thanks for notifying! Your test case 26296-duplicate-subscript-declaration.swift is added as part of #294 :-)

@radex
Copy link
Contributor

radex commented Dec 7, 2015

:)

@practicalswift practicalswift changed the title Sync with https://github.com/practicalswift/swift-compiler-crashes Compiler crashers: Sync with https://github.com/practicalswift/swift-compiler-crashes Dec 11, 2015
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
Actually update epoll events if needed when unregistering
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
Actually update epoll events if needed when unregistering

Signed-off-by: Daniel A. Steffen <[email protected]>
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants