[stdlib] Fix error in nextUp and nextDown #2801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
| @@ -171,6 +171,42 @@ FloatingPoint.test("Double/HashValueZero") { | |||
| expectEqual(zero.hashValue, negativeZero.hashValue) | |||
| } | |||
|
|
|||
| FloatingPoint.test("Float/NextUp") { | |||
| let values: [Float] = [-20, -2, -1, -0, 0, 1, 2, 20] | |||
There was a problem hiding this comment.
Could you change the tests to check the output exactly?
/// Pairs of consecutive floating point numbers as ordered by `nextUp`/`nextDown`.
let nextUpDownTests: [(Float, Float)] = [
(Float.nan, Float.nan),
(Float.infinity, Float.infinity),
(-Float.infinity, -Float.infinity),
(0x1.fffffep-1, 1.0), (1.0, 0x1.000002p+0),
(-0x1p-149, 0.0), (0.0, 0x1p-149),
(0x1.effffep-1, 0.96875), (0.96875, 0x1.f00002p-1),
]
FloatingPoint.test("Float.nextUp, .nextDown")
.forEach(in: nextUpDownTests) {
(prev, succ) in
expectEqual(succ.bitPattern, prev.nextUp.bitPattern)
expectEqual(prev.bitPattern, succ.nextDown.bitPattern)
expectEqual((-succ).bitPattern, (-prev).nextDown.bitPattern)
expectEqual((-prev).bitPattern, (-succ).nextUp.bitPattern)
}There was a problem hiding this comment.
Thanks, I didn't know about that forEach method! I've updated the tests.
|
@stephentyrone just fyi |
|
@swift-ci Please test |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This fixes an error in the
nextUpandnextDownimplementation and adds a test for verification.Before:
After:
Resolved bug number: n/a
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.