[CodeCompleiton] Avoid walking the whole module to find the delayed func #28014
Conversation
Previously delayed parsing was performed by AST walker 'ParseDelayedFunctionBodies' by finding "delayed" function decl from the AST of the whole module. This is not necessary. Optimize it by remembering the "delayed" function decl in 'PersistentParserState'. NOTE: 'SourceLoader' stopped using this delayed parsing mechanism in d8b745d rdar://problem/56819166
|
This will conflict with #27981. I will rebase when either PR is merged. |
|
@swift-ci Please smoke test |
There was a problem hiding this comment.
Functionally this LGTM, thanks for fixing! I think we should consider renaming these delayed-decl methods though. For one thing, it's a bit confusing to have two methods named parseAbstractFunctionBodyDelayed. More generally, we have delayed parsing in general, and then we have specific delayed parsing API for code-completion, such as delayDecl, hasDelayedDecl, etc. Maybe we should rename the code-completion specific parts so it's clear when you're using them? What do you think?
I agree it's confusing and I think renaming them is a good idea. Let's do that in separate PR. (filed rdar://problem/56926367) |
Previously delayed parsing was performed by AST walker
ParseDelayedFunctionBodiesby finding "delayed" function decl from the AST of the whole module. This is not necessary. Optimize it by remembering the "delayed" function decl inPersistentParserState.NOTE:
SourceLoaderstopped using this delayed parsing mechanism in d8b745drdar://problem/56819166