Skip to content

Fix tensorflow_osx_base build preset. #28018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Fix tensorflow_osx_base build preset. #28018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion utils/build-presets.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2152,7 +2152,7 @@ test-installable-package
reconfigure

swift-install-components=compiler;clang-resource-dir-symlink;stdlib;sdk-overlay;parser-lib;toolchain-tools;license;sourcekit-xpc-service;swift-remote-mirror;swift-remote-mirror-headers
llvm-install-components=llvm-cov;llvm-profdata;IndexStore;clang;clang-headers;compiler-rt;clangd
llvm-install-components=llvm-cov;llvm-profdata;IndexStore;clang;clang-resource-headers;compiler-rt;clangd
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: it would be much nicer to avoid these issues by reusing the mixin_osx_package_base preset for tensorflow_osx_base instead of duplicating it.

Here's a historical note for the tensorflow_osx_base preset:

# Note: tensorflow_osx_base does not mix in "buildbot_osx_package" or
# "mixin_osx_package_base" because they enable ios/tvos/watchos and tests by
# default.
# Instead, options are copied here individually.
[preset: tensorflow_osx_base]
mixin-preset=mixin_lightweight_assertions

We could try mixing in mixin_osx_package_base for tensorflow_osx_base and overriding ios/tvos/watchos with skip-ios/skip-tvos/skip-watchos.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed TF-941 to track this issue.

install-libcxx

# Path to the .tar.gz package.
Expand Down