Skip to content

[NFC] Plot The Demise of LazyResolver #28030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2019
Merged

[NFC] Plot The Demise of LazyResolver #28030

merged 2 commits into from
Nov 2, 2019

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Nov 2, 2019 •
edited
Loading

Between this and #28009, only LazyResolver::resolveImplicitMember exists and will soon be requestified away.

To facilitate its speedy demise, drop the TypeChecker dependency out of the multi-conformance checker and fold resolveImplicitConstructors into resolveImplicitMember.

@CodaFi CodaFi requested a review from DougGregor November 2, 2019 01:14
@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 2, 2019

@swift-ci please smoke test

@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 2, 2019

⛵️

@CodaFi CodaFi merged commit a73c1f4 into swiftlang:master Nov 2, 2019
@CodaFi CodaFi deleted the unit-normals branch November 2, 2019 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodaFi @slavapestov