[Diagnostics] Resolve SR-11677: Offer a better diagnostic when && is … #28033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
CodaFi
reviewed
Nov 2, 2019
CodaFi
reviewed
Nov 2, 2019
CodaFi
reviewed
Nov 2, 2019
CodaFi
requested changes
Nov 2, 2019
|
I still get tripped up on this bit of syntax, so thank you @RayZhao1998! |
…used in trailing where clause declaration
CodaFi
approved these changes
Nov 4, 2019
|
@swift-ci please smoke test |
|
Thanks! ⛵️ |
|
Thanks for your contribution! Please make sure to resolve the SR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
&&checker and improve the diagnostic to remind developer replacing&&with comma instead of garbage diagnostics.Resolves SR-11677