Skip to content

[IRGen] NFC: Add operator<< for MetadataResponse #28034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2019

Conversation

davezarzycki
Copy link
Contributor

Newer versions of clang are more reliable about emitting "used" functions, but that means that newer versions of clang can break the build if the dependencies of a "used" function aren't satisfied.

Newer versions of clang are more reliable about emitting "used"
functions, but that means that newer versions of clang can break the
build if the dependencies of a "used" function aren't satisfied.
@davezarzycki davezarzycki requested a review from rjmccall November 2, 2019 11:56
@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit ffc0f6f into swiftlang:master Nov 2, 2019
@davezarzycki davezarzycki deleted the pr28034 branch November 2, 2019 13:18
@rjmccall
Copy link
Contributor

rjmccall commented Nov 4, 2019

Was this used somewhere? I don't entirely understand the point of adding a debugging dump that doesn't seem to print out the state very faithfully.

@davezarzycki
Copy link
Contributor Author

If you look at #27950, you'll see that newer versions of clang faithfully emit an "attribute used" dump() function whereas older clangs might not. This means that the dependencies of the attribute used function (like operator<<) need to be there.

I CCed you on this bug because I thought you might care about the QoI of this output operator.

@rjmccall
Copy link
Contributor

rjmccall commented Nov 5, 2019

No, I understood that there was a use of this that you wanted to satisfy. I'm asking what that use was from.

@davezarzycki
Copy link
Contributor Author

Not anything more specific than including a header as far as I can tell. The clang error "backtrace" is in #27950 is what I observed and it is less than perfect/helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants