-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Move swiftpm to swift_build_support infra #28035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall, just some minor comments inline.
As discussed offline, I think it would be nice to remove the old logic from build-script-impl
to not have dead code lying around and see the difference in code size for build script logic.
utils/swift_build_support/swift_build_support/products/swiftpm.py
Outdated
Show resolved
Hide resolved
71ec850
to
03837f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now!
This will allow cleaning up most of the hacks in SwiftPM's build script. <rdar://problem/56220087>
Linux Toolchain (Ubuntu 16.04) Install command |
macOS toolchain builder succeeded but the status check wasn't updated. See: https://ci.swift.org/job/swift-PR-toolchain-osx/426/ |
Tested both mac and linux toolchains. |
Thanks to swiftlang/swift#28035, we can start simplifying the bootstrap script and remove lots of horrible hacks that we currently have. <rdar://problem/56849141>
Thanks to swiftlang/swift#28035, we can start simplifying the bootstrap script and remove lots of horrible hacks that we currently have. <rdar://problem/56849141>
Thanks to swiftlang/swift#28035, we can start simplifying the bootstrap script and remove lots of horrible hacks that we currently have. <rdar://problem/56849141>
Thanks to swiftlang/swift#28035, we can start simplifying the bootstrap script and remove lots of horrible hacks that we currently have. <rdar://problem/56849141>
This will allow cleaning up most of the hacks in SwiftPM's build script.
rdar://problem/56220087