Skip to content

Move swiftpm to swift_build_support infra #28035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2019
Merged

Conversation

aciidgh
Copy link
Contributor

@aciidgh aciidgh commented Nov 2, 2019

This will allow cleaning up most of the hacks in SwiftPM's build script.

rdar://problem/56220087

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, just some minor comments inline.

As discussed offline, I think it would be nice to remove the old logic from build-script-impl to not have dead code lying around and see the difference in code size for build script logic.

@aciidgh aciidgh force-pushed the omg-2 branch 2 times, most recently from 71ec850 to 03837f3 Compare November 3, 2019 02:56
@swiftlang swiftlang deleted a comment from swift-ci Nov 3, 2019
@swiftlang swiftlang deleted a comment from swift-ci Nov 3, 2019
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now!

This will allow cleaning up most of the hacks in SwiftPM's build script.

<rdar://problem/56220087>
@swift-ci
Copy link
Contributor

swift-ci commented Nov 3, 2019

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 7241030

Install command
tar zxf swift-PR-28035-310-ubuntu16.04.tar.gz
More info

@aciidgh
Copy link
Contributor Author

aciidgh commented Nov 3, 2019

macOS toolchain builder succeeded but the status check wasn't updated. See: https://ci.swift.org/job/swift-PR-toolchain-osx/426/

@aciidgh
Copy link
Contributor Author

aciidgh commented Nov 3, 2019

Tested both mac and linux toolchains.

@aciidgh aciidgh merged commit 8e4202d into swiftlang:master Nov 3, 2019
@aciidgh aciidgh deleted the omg-2 branch November 3, 2019 16:37
aciidgh added a commit to aciidgh/swift-package-manager that referenced this pull request Nov 3, 2019
Thanks to swiftlang/swift#28035, we can start
simplifying the bootstrap script and remove lots of horrible hacks that
we currently have.

<rdar://problem/56849141>
aciidgh added a commit to aciidgh/swift-package-manager that referenced this pull request Nov 3, 2019
Thanks to swiftlang/swift#28035, we can start
simplifying the bootstrap script and remove lots of horrible hacks that
we currently have.

<rdar://problem/56849141>
aciidgh added a commit to aciidgh/swift-package-manager that referenced this pull request Nov 3, 2019
Thanks to swiftlang/swift#28035, we can start
simplifying the bootstrap script and remove lots of horrible hacks that
we currently have.

<rdar://problem/56849141>
aciidgh added a commit to swiftlang/swift-package-manager that referenced this pull request Nov 4, 2019
Thanks to swiftlang/swift#28035, we can start
simplifying the bootstrap script and remove lots of horrible hacks that
we currently have.

<rdar://problem/56849141>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants