[NameLookup ASTScope] Factor ASTScope ordering #28039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci plese test |
davidungar
force-pushed
the
factor-ASTScope-ordering
branch
from
573c718 to
094a5f8
Compare
|
@swift-ci plese test |
davidungar
force-pushed
the
factor-ASTScope-ordering
branch
from
094a5f8 to
f162a84
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASTScopes must be searched in source order, and when creating them, must be created in source-order. But what is the ordering for a SourceRange? It must be consistent. This PR factors these uses of ordering, so that there is one place, which chooses the ordering of the end locations. It may also fix the problem for Windows, that isNotAfter was not a total order.