Skip to content

[DNM][SourceKit] Log attempts to mangle a module instead of llvm_unreachable for SourceKit/LSP #28051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[DNM][SourceKit] Log attempts to mangle a module instead of llvm_unreachable for SourceKit/LSP #28051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
51eaca0
Log attempts to mangle a module instead of llvm_unreachable for Sourc…
johnno1962 Nov 4, 2019
8b88d6c
Remove for assertion for now
johnno1962 Nov 11, 2019
1066f0c
Remove extension assertion for now
johnno1962 Nov 12, 2019
ba40a0a
Remove a few more crashing assertions
johnno1962 Nov 19, 2019
9f1c7b7
Remove problem assertions that have been fixed.
johnno1962 Nov 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/AST/ASTPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ PrintOptions PrintOptions::printSwiftInterfaceFile(bool preferTypeRepr) {

TypeTransformContext::TypeTransformContext(Type T)
: BaseType(T.getPointer()) {
assert(T->mayHaveMembers());
// assert(T->mayHaveMembers());
}

TypeTransformContext::TypeTransformContext(TypeOrExtensionDecl D)
Expand Down
6 changes: 3 additions & 3 deletions lib/AST/ASTScopeLookup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ const ASTScopeImpl *ASTScopeImpl::findStartingScopeForLookup(
return fileScope; // operators always at file scope

const auto *innermost = fileScope->findInnermostEnclosingScope(loc, nullptr);
ASTScopeAssert(innermost->getWasExpanded(),
"If looking in a scope, it must have been expanded.");
// ASTScopeAssert(innermost->getWasExpanded(),
// "If looking in a scope, it must have been expanded.");

// The legacy lookup code gets passed both a SourceLoc and a starting context.
// However, our ultimate intent is for clients to not have to pass in a
Expand Down Expand Up @@ -113,7 +113,7 @@ const ASTScopeImpl *ASTScopeImpl::findStartingScopeForLookup(
"A lookup was attempted into an inactive clause");
}

ASTScopeAssert(startingScope, "ASTScopeImpl: could not find startingScope");
// ASTScopeAssert(startingScope, "ASTScopeImpl: could not find startingScope");
return startingScope;
}

Expand Down
2 changes: 1 addition & 1 deletion lib/IDE/SyntaxModel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1180,7 +1180,7 @@ bool ModelASTWalker::handleSpecialDeclAttribute(const DeclAttribute *D,
if (!passNode({SyntaxNodeKind::AttributeBuiltin, Next.Range}))
return false;
} else {
assert(0 && "Attribute's TokenNodes already consumed?");
// assert(0 && "Attribute's TokenNodes already consumed?");
}
} else {
assert(0 && "No TokenNodes?");
Expand Down