build: check the compiler against the correct variable #28058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were checking the compiler ID against the name of the compiler binary. This happened to pass incorrectly on Windows, which hid the bug.
|
CC: @edymtt |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
I was testing a similar changes in #28056 as well -- since this is more complete, I will close mine in favor of this. |
edymtt
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were checking the compiler ID against the name of the compiler
binary. This happened to pass incorrectly on Windows, which hid the
bug.
Resolves dar://problem/56866783