[Diagnostics] Improve diagnostics for implicit (un)tupling. #28076
Conversation
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
Ugh, got a bunch of whitespace changes from the rebase. Force-pushed to remove those. @swift-ci please test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@swift-ci please test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@brentdax do the changes look good to you? I've added the fix-its for adding/deleting parens and tests for those. |
| "and trying to match that instead", ()) | ||
| WARNING(found_one_pattern_for_several_associated_values,none, | ||
| "enum case '%0' has %1 associated values; matching them as a tuple " | ||
| "is deprecated", (StringRef, unsigned)) |
There was a problem hiding this comment.
Apologies if I've paged something out, but why is this the only one of the three diagnostics which states that doing this is deprecated?
There was a problem hiding this comment.
In the other two cases, we most likely have a fix-it that either adds or removes parens (for example, you can look at the test cases), so I felt that providing an additional "this is deprecated" was not so useful. I can add that though, it is not a big deal.
There was a problem hiding this comment.
@brentdax what do you think of my response? Ok to not have the deprecated note because we are supplying fix-its? Or should I still add it?
|
@swift-ci please test |
Fixes rdar://problem/56436226.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Merging for now. We can tweak the diagnostic later again if desired. |
Fixes rdar://problem/56436226.