Skip to content

[Changelog] Add entry for unsound pointer diagnostics #28109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hamishknight
Copy link
Contributor

Add a changelog entry for #27695.

@hamishknight hamishknight requested a review from atrick November 6, 2019 16:07
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! But should we include some information about how developers should resolve these issues? Some of the diagnostics have hints. Others don't. I'm sure some devs will be confused. In some easily searchable place we should link each of the diagnostic message to an explanation and example of doing the thing safely. It seems like release notes might be the best place.

@airspeedswift would this be too much for the release notes? The alternative would be to post it on the forums and hope devs find it with a web search.

@hamishknight
Copy link
Contributor Author

@atrick I'd be happy to provide some examples in the changelog for ways in which users can resolve this. One question is what should we recommend for cases where the user is passing an optional array or string? I don't believe there's a straightforward workaround for those cases.

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hamishknight
Copy link
Contributor Author

@swift-ci please smoke test

@hamishknight
Copy link
Contributor Author

Spoke with @atrick, and we're going to merge this as-is. The diagnostics already suggest alternatives for the cases where there's a straightforward alternative, and I'll write up a forum post to try and help with some of the more tricky cases.

@hamishknight hamishknight merged commit 9fec658 into swiftlang:master Nov 9, 2019
@hamishknight hamishknight deleted the health-and-safety-pointers-changelog branch November 9, 2019 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants