Skip to content

[IDE] Fix CursorInfo crash on arg label when the called 'function' is actually a module decl. #28134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nathawes
Copy link
Contributor

@nathawes nathawes commented Nov 7, 2019

This fixes the crash @johnno1962 reported in #28051

@nathawes nathawes requested a review from benlangmuir November 7, 2019 21:50
@nathawes
Copy link
Contributor Author

nathawes commented Nov 7, 2019

@swift-ci please test

@johnno1962
Copy link
Contributor

Thanks. Checks out this end 👍 👍

@swift-ci
Copy link
Contributor

swift-ci commented Nov 7, 2019

Build failed
Swift Test OS X Platform
Git Sha - 1218613

@nathawes
Copy link
Contributor Author

nathawes commented Nov 8, 2019

@swift-ci please test OS X Platform

@nathawes nathawes merged commit 345bcdb into swiftlang:master Nov 8, 2019
@nathawes nathawes deleted the fix-cursor-info-on-call-arg-label-with-invalid-function branch November 8, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants