[AutoDiff] Update @differentiable attribute API/ABI status.
#28148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
changed the title
@differentiable attribute API/ABI status.@differentiable attribute API/ABI status.
|
@swift-ci Please test tensorflow |
|
CI passed. Running extended test suite now ( |
Mark `@differentiable` attribute as: - API/ABI stable to add. (The `@differentiable` declaration is unaffected.) - API/ABI breaking to remove.
dan-zheng
force-pushed
the
diff-attr-abi-api-status
branch
from
75cb9e5 to
4b697b5
Compare
|
Oops, I used the wrong ABI/API statuses.
Re-triggering CI and extended test suite. |
|
@swift-ci Please test tensorflow |
rxwei
approved these changes
Nov 8, 2019
dan-zheng
changed the title
@differentiable attribute API/ABI status.@differentiable attribute API/ABI status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark
@differentiableattribute as:@differentiabledeclaration is unaffected.)This is an experiment regarding #27506 (comment).
Context: the
(ABI|API)(Stable|Breaking)To(Add|Remove)tags were added in #27180 and became relevant for@differentiableduring theswift-DEVELOPMENT-SNAPSHOT-2019-09-16-a -> tensorflowmerge.At the time, few attributes used
Breaking(final,frozen,_fixed_layout). The previous default wasStable, so we used it for@differentiable. IfBreakingis used,swift-api-digesterdiagnoses API/ABI-breaking attribute additions/removals in the stdlib, which may cause issues. Verifying now.