[AutoDiff upstream] AST bits for @differentiable fn ty #28156
Merged
+267
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lattner
approved these changes
Nov 9, 2019
include/swift/AST/Types.h
Outdated
| @@ -3750,6 +3774,16 @@ class SILFunctionType final : public TypeBase, public llvm::FoldingSetNode, | |||
| // Is this function guaranteed to be no-escape by the type system? | |||
| bool isNoEscape() const { return Bits & NoEscapeMask; } | |||
|
|
|||
| bool isDifferentiable() const { | |||
| return getDifferentiabilityKind() > | |||
There was a problem hiding this comment.
nit, but it seems like != would be more natural here than >
| auto einfo = SILFunctionType::ExtInfo(representation, | ||
| flags.isPseudogeneric(), | ||
| !flags.isEscaping()); | ||
| auto einfo = SILFunctionType::ExtInfo( |
There was a problem hiding this comment.
Is there a mangling for these flags? If so, it seems like it should be plumbed in here for the demangler to use.
There was a problem hiding this comment.
We've got some mangling in the tensorflow branch. I will upstream it in a separate PR. There is a ticket for that: https://bugs.swift.org/browse/TF-948
marcrasi
force-pushed
the
diff-fn-ty-ast-bits
branch
from
fbbde63 to
1b8b0bc
Compare
|
@swift-ci please test and merge |
marcrasi
force-pushed
the
diff-fn-ty-ast-bits
branch
from
1b8b0bc to
40524de
Compare
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
marcrasi
force-pushed
the
diff-fn-ty-ast-bits
branch
from
40524de to
6413f43
Compare
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the AST bits necessary to represent
@differentiableAnyFunctionTypeandSILFunctionType. Plumbs these bits through parsing and printing so that they can be tested. Adds serialization for them.This resolves TF-871.
Intentionally omits any functionality based on these bits to keep this PR small. (e.g. typechecking that the
@differentiableattr is allowed on the types; lowering@differentiableAnyFunctionTypeto the corresponding@differentiableSILFunctionType)