Tiny associated type inference fixes #28157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slavapestov
commented
Nov 8, 2019
slavapestov
commented
- Regression test for https://bugs.swift.org/browse/SR-11392
- Fixes https://bugs.swift.org/browse/SR-11407 / rdar://problem/54979757
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
slavapestov
commented
Nov 8, 2019
| @@ -282,6 +282,9 @@ extension _NativeSet { | |||
| } | |||
|
|
|||
| extension _NativeSet: _SetBuffer { | |||
| @usableFromInline | |||
There was a problem hiding this comment.
This goes away in the next PR.
This forces the interface type, which we don't want to do here.
If a protocol requirement has a type that's a nested member
type of another member type, eg,
protocol P {
associatedtype A : Q
func f(_: A.B)
}
Then we don't actually want to use 'f()' to infer the witness
for 'A'. By avoiding doing so, we eliminate some cycles which
can allow some programs to type check that didn't before.
…type Previously we did this as a last resort if inference fails. The new behavior is technically source-breaking, but I suspect nobody relied on the old behavior. This can help avoid cycles by eliminating some unnecessary validation work. Fixes <https://bugs.swift.org/browse/SR-11407>, <rdar://problem/54979757>.
slavapestov
force-pushed
the
tiny-assoc-type-fixes
branch
from
71fff5b to
04fbcc0
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
This was referenced Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.