[android] Split the Android CI build presets. #28163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm building locally the preset, but I don’t have a way to force the PR in the Android CI machines. Hopefully I copied everything that was in the @swift-ci please smoke test |
ahoppen
reviewed
Nov 9, 2019
There was a problem hiding this comment.
I just ran a quick diff of the generated arguments. Looking really good from my perspective. One thing I noticed is that you are no longer passing --skip-build-benchmarks. Unless the benchmarks are not being built anyway or you need them, I would specify it because they take about 5 minutes to build.
Diff
'--lit-args=-v --time-tests' '--lit-args=-v --time-tests'
'--llvm-install-components=llvm-cov;llvm-profdata;IndexStore; '--llvm-install-components=llvm-cov;llvm-profdata;IndexStore;
'--swift-install-components=autolink-driver;compiler;clang-re '--swift-install-components=autolink-driver;compiler;clang-re
--android --android
--android-api-level=21 --android-api-level=21
--android-icu-data=arm_dir/libicudataswift.so --android-icu-data=arm_dir/libicudataswift.so
--android-icu-i18n-include=arm_dir/icu/source/i18n --android-icu-i18n-include=arm_dir/icu/source/i18n
--android-icu-i18n=arm_dir/libicui18nswift.so --android-icu-i18n=arm_dir/libicui18nswift.so
--android-icu-uc-include=arm_dir/icu/source/common --android-icu-uc-include=arm_dir/icu/source/common
--android-icu-uc=arm_dir/libicuucswift.so --android-icu-uc=arm_dir/libicuucswift.so
--android-ndk=ndk_path --android-ndk=ndk_path
--assertions --assertions
--assertions <
--build-ninja --build-ninja
--build-subdir=buildbot_linux --build-subdir=buildbot_linux
--build-swift-static-sdk-overlay --build-swift-static-sdk-overlay
--build-swift-static-stdlib --build-swift-static-stdlib
--build-swift-stdlib-unittest-extra --build-swift-stdlib-unittest-extra
--extra-cmake-options=-DSWIFT_ENABLE_LLD_LINKER:BOOL=OFF --extra-cmake-options=-DSWIFT_ENABLE_LLD_LINKER:BOOL=OFF
--foundation <
--skip-build-foundation <
--install-foundation <
--host-test --host-test
--indexstore-db <
--indexstore-db=0 <
--install-destdir=install_destdir --install-destdir=install_destdir
--install-libcxx --install-libcxx
--install-libicu --install-libicu
--install-prefix=/usr --install-prefix=/usr
--install-swift --install-swift
--installable-package=installable_package --installable-package=installable_package
--libcxx --libcxx
--libdispatch <
--skip-build-libdispatch <
--install-libdispatch <
--libicu --libicu
--llbuild <
--skip-build-llbuild <
--install-llbuild <
--lldb <
--skip-build-lldb <
--install-lldb <
--lldb-test-swift-only <
--long-test --long-test
--no-swift-stdlib-assertions --no-swift-stdlib-assertions
--reconfigure --reconfigure
--release --release
--release <
--skip-build-benchmarks <
--skip-build-playgroundsupport --skip-build-playgroundsupport
--skip-test-linux --skip-test-linux
--sourcekit-lsp <
--sourcekit-lsp=0 <
--install-sourcekit-lsp <
--stress-test --stress-test
--swift-enable-ast-verifier=0 --swift-enable-ast-verifier=0
--swiftpm <
--swiftpm=0 <
--install-swiftpm <
--install-swiftpm=0 <
--swiftsyntax <
--test --test
--test-installable-package <
--test-installable-package= <
--test-optimized --test-optimized
--toolchain-benchmarks <
--toolchain-benchmarks=0 <
--validation-test --validation-test
--xctest <
--skip-build-xctest <
--install-xctest <
utils/build-script utils/build-script
By not depending on buildbot_linux, the changes there will not affect the Android builders. It will mean having to move the intended changes manually, but it will hopefully be more stable.
drodriguez
force-pushed
the
android-split-build-preset
branch
from
df96b5b to
c366dc3
Compare
|
Re-added the @swift-ci please smoke test |
ahoppen
approved these changes
Nov 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not depending on buildbot_linux, the changes there will not affect
the Android builders. It will mean having to move the intended changes
manually, but it will hopefully be more stable.
The Android CI builds started failing after #27855 in
https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android/4401/ and https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android-arm64/2671/.
[Edit: correct PR link]