[ASTPrinter/CodeCompletion] Stop printing base type when possible #28165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
astprinter-rdar57033931
branch
2 times, most recently
from
38fc71e to
9566c50
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
benlangmuir
reviewed
Nov 19, 2019
rintaro
force-pushed
the
astprinter-rdar57033931
branch
from
9566c50 to
8366779
Compare
|
Does this fix SR-9868 as well? |
rintaro
force-pushed
the
astprinter-rdar57033931
branch
from
8366779 to
318bff6
Compare
benlangmuir
reviewed
Dec 17, 2019
rintaro
force-pushed
the
astprinter-rdar57033931
branch
from
318bff6 to
6da2ca7
Compare
benlangmuir
approved these changes
Dec 18, 2019
rdar://problem/47871647
|
@swift-ci Please smoke test |
Thanks for the heads up! It does. Added a test case for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/57033931
rdar://problem/47871647
https://bugs.swift.org/browse/SR-9868