Partially Revert #27862 #28171
Merged
Partially Revert #27862 #28171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
xedin
approved these changes
Nov 9, 2019
include/swift/AST/Decl.h
Outdated
| @@ -5214,7 +5214,7 @@ enum class ParamSpecifier : uint8_t { | |||
|
|
|||
| /// A function parameter declaration. | |||
| class ParamDecl : public VarDecl { | |||
| Identifier ArgumentName; | |||
| llvm::PointerIntPair<Identifier, 1, bool> ArgumentNameAndDestrutured; | |||
There was a problem hiding this comment.
Nit: "c" is missing Destrutured :)
| @@ -6,6 +6,7 @@ | |||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | |||
|
|
|||
| // rdar://56144412 | |||
| // XFAIL: asserts | |||
There was a problem hiding this comment.
Does this mean that this case started crashing again and has to be moved to "compiler_crashers"? 😢
When SE-110 was being implemented, we accidentally began to accept
closure parameter declarations that had no associated parameter names,
e.g.
foo { ([Int]) in /**/ }
This syntax has never been sanctioned by any version of Swift and should
be banned. However, the change was made long enough ago and there are
enough clients relying on this, that we cannot accept the source break
at the moment. For now, add a bit to ParamDecl that marks a parameter
as destructured, and back out setting the invalid bit on the type repr
for these kinds of declarations.
To prevent further spread of this syntax, stub in a warning that offers
to insert an anonymous parameter.
Resolves part of rdar://56673657 and improves QoI for errors like
rdar://56911630
CodaFi
force-pushed
the
one-one-ten-ded-consequences
branch
from
d6a36e1 to
dd1b157
Compare
|
@swift-ci please smoke test |
|
⛵️ |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SE-110 was being implemented, we accidentally began to accept
closure parameter declarations that had no associated parameter names,
e.g.
foo { ([Int]) in /**/ }
This syntax has never been sanctioned by any version of Swift and should
be banned. However, the change was made long enough ago and there are
enough clients relying on this, that we cannot accept the source break
at the moment. For now, add a bit to ParamDecl that marks a parameter
as destructured, and back out setting the invalid bit on the type repr
for these kinds of declarations.
To prevent further spread of this syntax, stub in a warning that offers
to insert an anonymous parameter.
Resolves part of rdar://56673657 and improves QoI for errors like
rdar://56911630