[windows] Avoid warning in header in test turning into fatal error. #28175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Windows, ClangImporter seems to execute with Microsoft compatibility, and there are some more warnings that do not happen in Unix. One of them seems to be -Wmicrosoft-enum-forward-reference which warns about forward defined enums, like the one that happens in this header. Since the -warnings-as-errors flag is now passed down to ClangImporter, this warning will make this test fail. Simply use the #pragma to disable the warning for this piece of code.
|
Since PR 28170 is also trying to fix a compilation problem that happens before this one, running the Windows tests at this moment will not succeed. @swift-ci please smoke test |
compnerd
approved these changes
Nov 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows, ClangImporter seems to execute with Microsoft compatibility,
and there are some more warnings that do not happen in Unix. One of them
seems to be -Wmicrosoft-enum-forward-reference which warns about forward
defined enums, like the one that happens in this header. Since the
-warnings-as-errors flag is now passed down to ClangImporter, this
warning will make this test fail.
Simply use the #pragma to disable the warning for this piece of code.
The problem was introduced in #28142 and started failing in https://ci-external.swift.org/job/oss-swift-windows-x86_64/1888/