[NFC] [DiagnosticEngine] Improve output for malformed diagnostic messages #28177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages This is NFC as long as you assume there are no bad diagnostics.
|
@swift-ci please smoke test |
beccadax
requested review from
slavapestov and
CodaFi
and removed request for
slavapestov
DougGregor
approved these changes
Nov 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the DiagnosticEngine so that, if we discover a mis-formatted diagnostic, we insert a hard-to-miss string into the message and continue. The idea here is to (a) make the location in the string and nature of the bug more obvious, and (b) make sure users clearly perceive the diagnostics as erroneous rather than misunderstanding them when information is missing.
This change is NFC as long as you assume there are no bad diagnostics. We don't currently test the compiler's behavior for malformed diagnostics; I suppose we could.