Skip to content

tests: type_checker_perf test rdar33688063 is often too slow for the fast dir #28184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Nov 11, 2019

rdar://problem/57050532

@xymus
Copy link
Contributor Author

xymus commented Nov 11, 2019

@swift-ci Please smoke test

@xymus
Copy link
Contributor Author

xymus commented Nov 11, 2019

@davezarzycki If you are keeping track, I had to move rdar33688063 to the slow dir too. It has been failing from time to time in PR testing: https://ci.swift.org/job/oss-swift-pr-test/8811/console

@xymus xymus merged commit ce6a1cb into swiftlang:master Nov 11, 2019
@davezarzycki
Copy link
Contributor

davezarzycki commented Nov 11, 2019

We might need to disable the test. It is fast on fast machines and slow on slow machines. See:

https://bugs.swift.org/browse/SR-11754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants