[windows] Quote argument for Windows compatibility. #28199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Windows the dollar doesn't introduce variables, so it doesn't need to be escaped, and was creating an error when running the test on Windows. Howerver, the unescaped dollar will be interpreted like a variable in Unix shells, and will fail the test. The solution is quoting the inside of the argument, which disables the variable substitution on Linux, and doesn't seem to affect the Windows command line parser.
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
marcrasi
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows the dollar doesn't introduce variables, so it doesn't need to
be escaped, and was creating an error when running the test on Windows.
However, the unescaped dollar will be interpreted like a variable in
Unix shells, and will fail the test. The solution is quoting the inside
of the argument, which disables the variable substitution on Linux, and
doesn't seem to affect the Windows command line parser.
The error was introduced in #28027 and started appearing in CI on Friday afternoon. https://ci-external.swift.org/job/oss-swift-windows-x86_64/1924/ shows the error in a run from today.