[Diagnostics][SourceKit] Expose diagnostic educational notes through SourceKit requests #28203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
changed the title
…SourceKit requests
owenv
force-pushed
the
educational-notes-sourcekit
branch
from
9c0357a to
b52c6f4
Compare
owenv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #28052 , which only included them in printed terminal output.
Like the rest of the feature, this is gated behind
-Xfrontend -enable-descriptive-diagnosticssince it's experimental. I'm not really sure what the process is for making changes to the protocol, but this should be backwards compatible at least.Marking this as a draft for now because I'm not sure what the performance implications are of passing the entire text of educational notes in a response dict over xpc. The alternatives I've come up with so far are: