[AutoDiff] Destroy unused pullback direct results. #28207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test tensorflow |
rxwei
reviewed
Nov 12, 2019
dan-zheng
changed the title
rxwei
reviewed
Nov 12, 2019
In `PullbackEmitter::visitApplyInst`, destroy unused pullback direct results. This is needed for VJPs extracted from `@differentiable` function callees, where the `@differentiable` function's differentiation parameter indices are a superset of the active `apply` parameter indices. Resolves TF-953.
rxwei
approved these changes
Nov 12, 2019
|
@swift-ci Please test tensorflow |
bgogul
pushed a commit
that referenced
this pull request
Nov 19, 2019
In `PullbackEmitter::visitApplyInst`, destroy unused pullback direct results. This is needed for VJPs extracted from `@differentiable` function callees, where the `@differentiable` function's differentiation parameter indices are a superset of the active `apply` parameter indices. Resolves TF-953.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
PullbackEmitter::visitApplyInst, destroy unused pullback direct results.This is needed for VJPs extracted from
@differentiablefunction callees,where the
@differentiablefunction's differentiation parameter indices area superset of the active
applyparameter indices.Resolves TF-928.