Skip to content

[AutoDiff upstream] Update @differentiable syntax. #28211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

dan-zheng
Copy link
Contributor

@dan-zheng dan-zheng commented Nov 12, 2019

Clean up unused syntax components and fix description strings.

Friend PR: swiftlang/swift-syntax#179
Resolves comments: #27506 (review)


Must be tested with swiftlang/swift-syntax#179 so that --swiftsyntax-verify-generated-files passes.

Clean up unused syntax components and fix description strings.
dan-zheng added a commit to dan-zheng/swift-syntax that referenced this pull request Nov 12, 2019
Update gyb-generated files for `@differentiable` attribute.
Clean up unused syntax components and fix description strings.

Friend PR: swiftlang/swift#28211
@dan-zheng dan-zheng requested a review from akyrtzi November 12, 2019 17:36
@akyrtzi
Copy link
Contributor

akyrtzi commented Nov 12, 2019

swiftlang/swift-syntax#179

@swift-ci smoke test

@dan-zheng
Copy link
Contributor Author

@akyrtzi: could you please help merge this PR and swiftlang/swift-syntax#179?

@akyrtzi akyrtzi merged commit 28d4614 into swiftlang:master Nov 12, 2019
@dan-zheng dan-zheng deleted the differentiable-attr-syntax branch November 12, 2019 20:37
dan-zheng added a commit that referenced this pull request Nov 12, 2019
Clean up unused syntax components and fix description strings.
Upstream PR: #28211
bgogul pushed a commit that referenced this pull request Nov 19, 2019
Clean up unused syntax components and fix description strings.
Upstream PR: #28211
dan-zheng added a commit to dan-zheng/swift-syntax that referenced this pull request Apr 8, 2020
Update gyb-generated files for `@differentiable` attribute.
Clean up unused syntax components and fix description strings.

Friend PR: swiftlang/swift#28211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants