[AutoDiff] add negative tests found by random code generator #28219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
Nice! Could you please move these tests to the recently created test/AutoDiff/compiler_crashers directory and use the same conventions?
- Filename has the format
tfxxx-short-crash-description.swift, referencing aTFJIRA issue. RUNlines use:// RUN: not --crash <command> // REQUIRES: asserts
- Tests are moved to
test/AutoDiff/compiler_crashers_fixedupon being fixed.
Note: I set up test/AutoDiff/compiler_crashers{,_fixed} based on validation-test/test/compiler_crashers{,_fixed}.
marcrasi
force-pushed
the
add-generated-negative-tests
branch
from
2736e96 to
310d789
Compare
|
@swift-ci please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the testcases in seems so much easier and better than filing JIRA tickets, so here are two checked-in negative tests created by the random code generator.
generated0002.swiftof them already has a JIRA ticket https://bugs.swift.org/browse/TF-891.generated0001.swiftis a new discovery today.