Skip to content

[CodeCompletion] Avoid unnecessary performTypeChecking() in REPL #28228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[CodeCompletion] Avoid unnecessary performTypeChecking() in REPL #28228

wants to merge 1 commit into from

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Nov 13, 2019

This is a leftover from #27981 .

@rintaro
Copy link
Member Author

rintaro commented Nov 13, 2019

@swift-ci Please smoke test

@CodaFi
Copy link
Contributor

CodaFi commented Nov 13, 2019

We really oughta just remove code completion in the REPL at this point...

@rintaro rintaro force-pushed the ide-completion-repltypechck branch from 73d290d to a3b2d89 Compare November 13, 2019 07:29
@rintaro
Copy link
Member Author

rintaro commented Nov 13, 2019

@CodaFi I agree. That's buggy already.

@rintaro
Copy link
Member Author

rintaro commented Nov 13, 2019

@swift-ci Please smoke test

@CodaFi CodaFi mentioned this pull request Apr 19, 2020
Merged
@CodaFi
Copy link
Contributor

CodaFi commented Apr 20, 2020

Superseded by #31135. Thanks!

@CodaFi CodaFi closed this Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @CodaFi