Skip to content

[Gardening] Strip TypeChecker of its ASTContext #28231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 13, 2019

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Nov 13, 2019

Clean up TypeChecker's header a bit by removing dead members and friends and putting the doc comments back in order.

If you can get a TypeChecker at this point, you had one all along.

Its constructor and destructor are now defaultable.
TypeChecker has no friends.
Try to move the doc comments for the name lookup section so that it actually contains name-lookup-related things.
It's only used from code completion, but it has a dependency on operator lookup so it's gotta stay a member for now
@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 13, 2019

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit d53c015 into swiftlang:master Nov 13, 2019
@CodaFi CodaFi deleted the security-types branch November 13, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants