Skip to content

[windows] Enable SourceKit tests in CI. #28242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

drodriguez
Copy link
Contributor

Small change to see what's broken in the community CI.

@drodriguez
Copy link
Contributor Author

@swift-ci please clean test Windows platform

@gmittert
Copy link
Contributor

gmittert commented Nov 13, 2019

I know there are still a handful of broken Sourcekit tests on Windows locally on my machine:

Failing Tests (11):
    Swift(windows-x86_64) :: SourceKit/CodeComplete/injected_vfs.swift
    Swift(windows-x86_64) :: SourceKit/CodeComplete/injected_vfs_complete_open.swift
    Swift(windows-x86_64) :: SourceKit/CodeComplete/injected_vfs_swiftinterface.swift
    Swift(windows-x86_64) :: SourceKit/CompileNotifications/code-completion.swift
    Swift(windows-x86_64) :: SourceKit/CompileNotifications/type-context-info.swift
    Swift(windows-x86_64) :: SourceKit/CursorInfo/injected_vfs.swift
    Swift(windows-x86_64) :: SourceKit/Sema/injected_vfs.swift
    Swift(windows-x86_64) :: SourceKit/Sema/injected_vfs_after_edit.swift
    Swift(windows-x86_64) :: SourceKit/Sema/injected_vfs_sourcetext.swift
    Swift(windows-x86_64) :: SourceKit/Sema/sema_playground.swift
    Swift(windows-x86_64) :: SourceKit/SyntaxMapData/diags.swift

By my count, but I'm good to enable these on the Windows CI so we can see that they're broken

@gmittert
Copy link
Contributor

@swift-ci please smoke test

@gmittert
Copy link
Contributor

Looks like there are 3 fewer failures than I have locally so that's good. I believe the notification tests and the playground test fail because it generates an error message for both S:\... and C:\... when it only expects on error and it might not do that on CI depending on how it's set up.

@drodriguez
Copy link
Contributor Author

I think I have a small fix for the diags.swift one which should be isolated, and hopefully doesn’t create more problems.

It is good that the sed problems I was having doesn’t happen in this case.

I also think that the %drive changes in the test might get the VFS failures down to 2 or 3 (one of them probably SourceKit/CodeComplete/injected_vfs_swiftinterface.swift)

@drodriguez
Copy link
Contributor Author

Included as part of #28250.

@drodriguez drodriguez closed this Nov 18, 2019
@drodriguez drodriguez deleted the windows-enable-sourcekit-tests-in-ci branch November 18, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants