Drop the TopLevelContext from the high-level type checker entrypoints #28246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bit has historically survived typechecking and parsing across source files. Stick it where we stick the other global state. This also means we don't have to thread TopLevelContext around anymore when invoking high-level typechecking entrypoints.
It's really not important where it manages to find this unique value, but it's gotta get it from somewhere. Shameless steal DiscriminatorFinder from DebuggerTransform to scrobble for the next available discriminator value.
|
Whoops, can't do this yet. |
CodaFi
added a commit
to CodaFi/llvm-project
that referenced
this pull request
Nov 13, 2019
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please smoke test |
|
⛵️ |
JDevlieghere
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Nov 18, 2019
Supports swiftlang/swift#28246 (cherry picked from commit 81dff85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopLevelContext's only use was as an entropy service for top-level autoclosure discriminator generation. It's really not important where we get this information from, so just put it on the ASTContext so we don't have to hand around these parameters when calling the high-level type checking entrypoints.
There was one caller that needed some extra handling: REPLChecker. I'm not ashamed of stealing the discriminator scrobbler from DebuggerTransform to satisfy that dependency. This codepath can take the hit of the small performance degradation this will cause for extremely large, many-file, closure-filled REPL inputs.
Ultimately, this makes it easier to stick in a high-level request for type checking an entire file so we can start working on online request-based dependencies.