[AutoDiff] NFC: gardening. #28251
Merged
[AutoDiff] NFC: gardening. #28251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
commented
Nov 14, 2019
| @@ -5971,7 +5979,7 @@ class PullbackEmitter final : public SILInstructionVisitor<PullbackEmitter> { | |||
| auto insertion = valueMap.try_emplace({origBB, originalValue}, | |||
| adjointValue); | |||
| LLVM_DEBUG(getADDebugStream() | |||
| << "The existing adjoint value will be replaced: " | |||
There was a problem hiding this comment.
Note: the previous message made it sound like the "existing (old) adjoint value" is displayed instead of the new value.
rxwei
reviewed
Nov 14, 2019
Improve documentation comments and differentiation debug output. Add correctness assertions. Wrap lines to 80 columns. Change the `DenseMap` key type for `LinearMapInfo::linearMapFieldMap` from `SILInstruction *` to `ApplyInst *`, since stored properties (`struct_extract` instructions) cannot have custom derivatives.
dan-zheng
force-pushed
the
autodiff-gardening
branch
from
78d87e0 to
c83e5aa
Compare
rxwei
approved these changes
Nov 14, 2019
|
@swift-ci Please test tensorflow |
bgogul
pushed a commit
that referenced
this pull request
Nov 19, 2019
Improve documentation comments and differentiation debug output. Add correctness assertions. Wrap lines to 80 columns. Change the `DenseMap` key type for `LinearMapInfo::linearMapFieldMap` from `SILInstruction *` to `ApplyInst *`, since stored properties (`struct_extract` instructions) cannot have custom derivatives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve documentation comments and differentiation debug output.
Add correctness assertions.
Wrap lines to 80 columns.
Change the
DenseMapkey type forLinearMapInfo::linearMapFieldMapfrom
SILInstruction *toApplyInst *, since stored properties(
struct_extractinstructions) cannot have custom derivatives after#25151.