Skip to content

[Testing] Add missing REQUIRES: asan_runtime #28254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

davezarzycki
Copy link
Contributor

No description provided.

@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test and merge

@davezarzycki
Copy link
Contributor Author

Spurious LLDB failure?

@swift-ci please smoke test macos

@davezarzycki davezarzycki merged commit 10aac56 into swiftlang:master Nov 14, 2019
@davezarzycki davezarzycki deleted the pr28254 branch November 14, 2019 10:58
@danliew-apple
Copy link
Contributor

Hmm I'm guessing this is because of the first RUN line.

// RUN: %swiftc_driver -v -sanitize-recover=address %s -o %t 2>&1 | %FileCheck -check-prefix=SAN_RECOVER_MISSING_INSTRUMENTATION_OPTION %s

which invokes the entire compiler rather than just the driver. We should probably split the test so we can still test the driver only case when the ASan runtime is not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants