Skip to content

Add support in SILLoop::canDuplicate for PartialApplyInst. #28261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Add support in SILLoop::canDuplicate for PartialApplyInst. #28261

merged 1 commit into from
Nov 14, 2019

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Nov 14, 2019

Which may also generate stack allocations.

Which may also generate stack allocations.
@atrick
Copy link
Contributor Author

atrick commented Nov 14, 2019

@swift-ci test

@atrick
Copy link
Contributor Author

atrick commented Nov 14, 2019

@swift-ci benchmark

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swift-ci
Copy link
Contributor

Performance: -O

Improvement OLD NEW DELTA RATIO
FlattenListFlatMap 5008 4338 -13.4% 1.15x (?)

Code size: -O

Performance: -Osize

Improvement OLD NEW DELTA RATIO
ObjectiveCBridgeStubToArrayOfNSString2 2860 2620 -8.4% 1.09x (?)
PrefixCountableRange 14 13 -7.1% 1.08x (?)

Code size: -Osize

Performance: -Onone

Regression OLD NEW DELTA RATIO
ArrayAppendGenericStructs 630 1550 +146.0% 0.41x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@atrick atrick merged commit 1813b8b into swiftlang:master Nov 14, 2019
@atrick atrick deleted the check-partialapply branch December 23, 2019 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants