[windows] Adapt pcm-emit-and-import for Windows separators. #28267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test Windows platform |
|
@swift-ci please smoke test |
|
Sorry about that! Thanks for the fix—I'll keep that in mind for LLVM-printed paths in the future. |
DougGregor
approved these changes
Nov 14, 2019
|
I would love that there was a better way of doing this, but I cannot find a good way of checking for paths that it is multiplatform without overhead for the contributors. It is me the one that is sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #28107 and started failing in https://ci-external.swift.org/job/oss-swift-windows-x86_64/1963/
/cc @allevato @DougGregor