[windows] Replace SourceKit cleaning regexes for Python script. #28298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmittert
approved these changes
Nov 16, 2019
|
@swift-ci please smoke test |
compnerd
approved these changes
Nov 16, 2019
|
@swift-ci please test Windows platform |
|
@swift-ci please smoke test macOS platform |
|
It’s failing in the Python linter. I will have a look and fix it when I have time. |
The quoting of the sed commands was creating problems in my Windows installation. I am unsure if the implementation of sed.exe is different or the cmd.exe is different. In order to avoid problems in different machines, replace the piped sed commands into only one python script. This should be multiplatform and should execute the same in any of them. It also remove a lot of the extra quoting and escaping, and avoids 5 processes for only just one.
drodriguez
force-pushed
the
windows-python-sed_clean
branch
from
d468948 to
8470083
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform [Edit: https://ci-external.swift.org/view/Pull%20Request/job/swift-PR-windows/197/] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quoting of the sed commands was creating problems in my Windows
installation. I am unsure if the implementation of sed.exe is different
or the cmd.exe is different.
In order to avoid problems in different machines, replace the piped sed
commands into only one python script. This should be multiplatform and
should execute the same in any of them. It also remove a lot of the
extra quoting and escaping, and avoids 5 processes for only just one.