[CodeCompletion] Suggest the property name in its didSet clause #28319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
ide-completion-rdar49697202
branch
from
f68a140 to
8e93a9e
Compare
|
@swift-ci Please smoke test |
benlangmuir
reviewed
Dec 4, 2019
| @@ -2168,6 +2168,12 @@ class CompletionLookup final : public swift::VisibleDeclConsumer { | |||
| addValueBaseName(Builder, Name); | |||
| setClangDeclKeywords(VD, Pairs, Builder); | |||
|
|
|||
| // "not recommended" in its own getter. | |||
There was a problem hiding this comment.
Will this impact keypaths? I think that would still be "okay". Technically you can also call the setter safely from the getter if it doesn't mutually recurse, but I don't care much about that case.
There was a problem hiding this comment.
It did. I updated the PR to ensure it doesn't mark it "NotRecommended" in case of keypaths or explicit self.
I want to mark it because the compiler emit warnings for them:
class MyClass {
var value: Int {
get {
value = 12 // warning: attempting to access 'value' within its own getter
// note: access 'self' explicitly to silence this warning
return 1
}
set {
}
}
}
rintaro
force-pushed
the
ide-completion-rdar49697202
branch
from
8e93a9e to
493fa4e
Compare
Previously, property names are hidden in the whole range of the declarations. Now, it's only hidden in its own initializer range. rdar://problem/49697202
rintaro
force-pushed
the
ide-completion-rdar49697202
branch
from
493fa4e to
ad4b9df
Compare
|
@swift-ci Please smoke test |
benlangmuir
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, property names are hidden in the whole range of the declarations. Now, it's only hidden in its own initializer range.
Also, mark them as "NotRecommended" in their
getaccessors.rdar://problem/49697202