Revert "build: remove SWIFT_NEED_EXPLICIT_LIBDISPATCH (NFC)"
#28379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 18570c7 because it breaks building on platforms that do not want or need libdispatch.
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
I really hope that I didn't miss a policy change, but I don't think I did. Reverting |
|
@davezarzycki - bleh, there was a stupid mistake in the patch that somehow made it through the build tests. I had a fix for it in #28360 but could not get it merged due to the CI being down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 18570c7 (pull request #28338) because it breaks building on platforms that do not want or need libdispatch.