[NFC] Refactor Overload Resolution a Bit #28386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have it function more like getTypeOfMemberReference and clean up its caller a bit
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
xedin
approved these changes
Nov 20, 2019
slavapestov
reviewed
Nov 20, 2019
| /// checking semantics, compute the type of the reference. For now, follow | ||
| /// the lead of \c getTypeOfMemberReference and return a pair of | ||
| /// the full opened type and the reference's type. | ||
| static std::pair<Type, Type> getTypeOfReferenceWithSpecialTypeCheckingSemantics( |
There was a problem hiding this comment.
It looks like both elements of the pair are equal in every case below? Should this just return a single Type?
There was a problem hiding this comment.
It should, but I'm trying to maintain some consistency here while I go clean up the rest of the callers. I want to see if I can remove all the pairs.
There was a problem hiding this comment.
*Consistency with respect to the std::ties in the caller, I should say.
|
@swift-ci please smoke test Linux platform |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit pulls the out-parameters in
resolveOverloadForDeclWithSpecialTypeCheckingSemanticsout as its return type and adjusts the caller inConstraintSystem::resolveOverloadto have a bit of a simpler structure.The second commit further clarifies the structure of
ConstraintSystem::resolveOverloadby pulling out the parts that readjust the constraint system and the type of the reference to the selected overload into their own private helper function. It also readjusts its structure from a branch-tree on the overload kind to a switch.