[swift-ide-test] Mimic SourceKit's setup when testing syntactic requests #28388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
rintaro
approved these changes
Dec 3, 2019
| Invocation.getTypeCheckerOptions(), | ||
| Invocation.getModuleName(), | ||
| SynTreeCreator, | ||
| Invocation.getMainFileSyntaxParsingCache()); |
nathawes
force-pushed
the
swift-ide-test-syntactic-walker-setup
branch
from
eb0a01d to
e0f63b1
Compare
|
@swift-ci please test and merge |
…tic requests SourceKit doesn't set up a compiler instance, just a parser, for its syntactic requests (document structure and syntax coloring). This updates swift-ide-test to minic this setup to ensure the StructureAnnotator/PrintSyntaxColorWalker and underlying SyntaxModelWalker handle this setup (which has no type-checker installed) for all our swift-ide-test based tests. Resolves rdar://problem/57202584
nathawes
force-pushed
the
swift-ide-test-syntactic-walker-setup
branch
from
e0f63b1 to
ddd714e
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceKit doesn't set up a compiler instance, just a parser, for its syntactic requests (document structure and syntax coloring). This updates
swift-ide-testto minic this setup to ensure theStructureAnnotator/PrintSyntaxColorWalkerand underlyingSyntaxModelWalkerhandle this setup (which has no type-checker installed) for all ourswift-ide-testbased tests.This PR also factors out some common error handling code.
Resolves rdar://problem/57202584