[ASTMangler] Don't verify the USR mangling for invalid decls #28397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
USRs generated for the index store and sourcekit requests for invalid decls are best-effort – we don't need to guarantee they can be de- or re-mangled.
|
@swift-ci please test |
akyrtzi
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USRs generated for the index store and IDE requests for invalid decls are best-effort. They're just serving as a mostly-unique id for use when talking to the indexer in this case, so we don't need to guarantee they can be de- or re-mangled.
We were hitting some of these cases in the projects and crash traces mentioned in #28051