[TypeChecker] User interface type while validating keypath dynamic su… #28421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
There's two more callers in this file that can use the interface type. |
xedin
force-pushed
the
switch-dyn-keypath-to-interface-type
branch
from
36b6246 to
2ee7d31
Compare
|
@CodaFi I've fixed one more usage but I'd like to keep this PR about |
|
@swift-ci please smoke test |
CodaFi
approved these changes
Nov 21, 2019
|
@CodaFi Looks like with |
|
So then |
|
Sounds good! |
…bscript parameter Avoid unnecessary parameter type substitutions.
xedin
force-pushed
the
switch-dyn-keypath-to-interface-type
branch
from
2ee7d31 to
b5f89cf
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bscript parameter
Avoid unnecessary parameter type substitutions.