[windows][android] Support in conditional_conformances.swift test #28422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed a couple of new lines to support Windows MSVC and Android AArch64 in the test. Android ARMv7 is not running this test because the limitation of 64 bits pointer size.
drodriguez
force-pushed
the
android-windows-conditional-conformances-test
branch
from
e5083bf to
5f977fc
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed a couple of new lines to support Windows MSVC and Android AArch64
in the test.
Android ARMv7 is not running this test because the limitation of 64 bits
pointer size.
Introduced in #28337 and first seen in https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android-arm64/2831/ and https://ci-external.swift.org/job/oss-swift-windows-x86_64/2048/