Skip to content

Add REQUIRES: asserts to activity_analysis.swift #28428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2019
Merged

Add REQUIRES: asserts to activity_analysis.swift #28428

merged 1 commit into from
Nov 22, 2019

Conversation

bgogul
Copy link
Contributor

@bgogul bgogul commented Nov 22, 2019

No description provided.

@bgogul
Copy link
Contributor Author

bgogul commented Nov 22, 2019

@swift-ci please test tensorflow

@bgogul bgogul requested a review from dan-zheng November 22, 2019 00:51
dan-zheng
dan-zheng approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We should be careful to add REQUIRES: asserts to all tests that use -Xllvm -debug-only=differentiation (or any other assertions-only behavior) from now on.

Issues like this would be caught by CI if we had CI machines that didn't run with assertions.

@dan-zheng dan-zheng merged commit 9775a1a into tensorflow Nov 22, 2019
@dan-zheng dan-zheng deleted the bgogul-patch-1 branch November 22, 2019 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-zheng dan-zheng dan-zheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgogul @dan-zheng