Skip to content

Fix memory violation when build record is bad. #28444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

davidungar
Copy link
Contributor

@davidungar davidungar commented Nov 22, 2019

Return a string instead of a StringRef for why incrementality is being disabled.
rdar://57437165 & rdar://57540981

@davidungar
Copy link
Contributor Author

@swift-ci please smoke test

@davidungar
Copy link
Contributor Author

@swift-ci please smoke test asan

@shahmishal
Copy link
Member

@swift-ci test macOS

@shahmishal
Copy link
Member

@swift-ci please asan test

@davidungar
Copy link
Contributor Author

@swift-ci please asan test

1 similar comment
@shahmishal
Copy link
Member

@swift-ci please asan test

@shahmishal
Copy link
Member

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 5b0c4b2

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 5b0c4b2

@davidungar davidungar merged commit 448d9df into swiftlang:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants