[SILGEN] Inject "willThrow" hooks after foreign error propagation. #28455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nches. The hook is intended to be used by debuggers to catch the point a `throw` happened in user source. It's unnecessary and undesirable to hook in places where an already-thrown error is just being implicitly propagated.
jckarter
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
LGTM. @dcci or @adrian-prantl might want to look over this too. Does this adequately preserve coverage for "Swift Error" breakpoints?
|
@kitaisreal Can you explain why it is safe to omit these specific willThrow calls in this patch? |
|
The error should already have been thrown at the point these calls were being inserted. This patch should affect paths where an already-thrown error is being propagated up the callstack. |
|
That seems reasonable then. |
dcci
approved these changes
Dec 2, 2019
|
@swift-ci test |
|
⛵️ |
|
@kitaisreal Don't forget to update the SR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jckarter
More information in ticket: https://bugs.swift.org/browse/SR-11803